Fixed absolute path calculation for workspace resources #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Previously it was assumed that projects are physically stored below the workspace directory. When projects are located e.g. in a git repository and imported into the workspace this assumption does not hold. This was fixed with a proper lookup. * Changed API of the convertToAbsolutePath method to take a string instead of a file, since all callers had to create a file from a string anyway. Signed-off-by: Max Bureck <[email protected]>
Boereck
force-pushed
the
absolute-path-fix
branch
from
a9e5dbe to
38a8259
Compare
Boereck
added a commit
to Boereck/corrosion
that referenced
this pull request
Oct 15, 2018
convertToAbsolutePath is now taking path directly in relative path case instead of converting file back to a relative path string. Signed-off-by: Max Bureck <[email protected]>
mickaelistria
pushed a commit
that referenced
this pull request
Oct 15, 2018
convertToAbsolutePath is now taking path directly in relative path case instead of converting file back to a relative path string. Signed-off-by: Max Bureck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was assumed that projects are physically stored below
the workspace directory. When projects are located e.g. in a git
repository and imported into the workspace this assumption does not
hold. This was fixed with a proper lookup.
Changed API of the convertToAbsolutePath method to take a string
instead of a file, since all callers had to create a file from a
string anyway.